nevi-me commented on a change in pull request #8402:
URL: https://github.com/apache/arrow/pull/8402#discussion_r512225924
##########
File path: cpp/src/arrow/ipc/metadata_internal.cc
##########
@@ -427,8 +427,7 @@ static Status GetDictionaryEncoding(FBB& fbb, const
std::shared_ptr<Field>& fiel
const DictionaryType& type, int64_t
dictionary_id,
DictionaryOffset* out) {
// We assume that the dictionary index type (as an integer) has already been
- // validated elsewhere, and can safely assume we are dealing with signed
- // integers
+ // validated elsewhere, and can safely assume we are dealing with integers
Review comment:
Yes please, unless it's fine @emkornfield ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
