carols10cents commented on a change in pull request #8402:
URL: https://github.com/apache/arrow/pull/8402#discussion_r512222911
##########
File path: rust/parquet/src/arrow/array_reader.rs
##########
@@ -503,7 +492,14 @@ where
data_buffer.into_iter().map(Some).collect()
};
- self.converter.convert(data)
+ // TODO: I did this quickly without thinking through it, there might
be edge cases to consider
Review comment:
This looks fine to me because this function originally returned this
`Result`; I'm not sure what edge cases there might be...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
