carols10cents commented on pull request #8402: URL: https://github.com/apache/arrow/pull/8402#issuecomment-716784320
@nevi-me thank you so so so much! The code is SO much nicer now. I rebased this branch on the rust-parquet-arrow-writer branch, cherry-picked your latest commit, and made some further changes. I was able to get rid of the `CastConverter`s and `CastRecordReader`!! I left comments on the spots that I'm not sure how to resolve... And yes, as you noted, I cherry-picked the "We need a custom comparison of ArrayData" commit from your ARROW-7842-cherry branch so that more tests would work on this branch. Do you think that commit is ready to go, even if the other commits on that branch aren't? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
