nevi-me commented on a change in pull request #8402:
URL: https://github.com/apache/arrow/pull/8402#discussion_r512227266
##########
File path: rust/parquet/src/arrow/array_reader.rs
##########
@@ -503,7 +492,14 @@ where
data_buffer.into_iter().map(Some).collect()
};
- self.converter.convert(data)
+ // TODO: I did this quickly without thinking through it, there might
be edge cases to consider
Review comment:
I wrote it in a hurry, so couldn't stop to think of there's anything I
might miss. Happy that there isn't
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
