winding-lines commented on code in PR #3436:
URL: https://github.com/apache/arrow-rs/pull/3436#discussion_r1060595962
##########
object_store/src/azure/mod.rs:
##########
@@ -367,13 +375,103 @@ pub struct MicrosoftAzureBuilder {
client_secret: Option<String>,
tenant_id: Option<String>,
sas_query_pairs: Option<Vec<(String, String)>>,
+ sas_key: Option<String>,
authority_host: Option<String>,
url: Option<String>,
use_emulator: bool,
retry_config: RetryConfig,
client_options: ClientOptions,
}
+#[derive(PartialEq, Eq)]
+enum AzureConfigKey {
+ /// The name of the azure storage account
+ ///
+ /// Supported keys:
Review Comment:
Ok I see now why a second layer is needed: you want to support multiple
variants of the environment variables. This is ok with me, but supporting more
than 2-3 will be confusing in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
