roeap commented on code in PR #3436:
URL: https://github.com/apache/arrow-rs/pull/3436#discussion_r1060935881
##########
object_store/src/azure/mod.rs:
##########
@@ -367,13 +375,103 @@ pub struct MicrosoftAzureBuilder {
client_secret: Option<String>,
tenant_id: Option<String>,
sas_query_pairs: Option<Vec<(String, String)>>,
+ sas_key: Option<String>,
authority_host: Option<String>,
url: Option<String>,
use_emulator: bool,
retry_config: RetryConfig,
client_options: ClientOptions,
}
+#[derive(PartialEq, Eq)]
+enum AzureConfigKey {
+ /// The name of the azure storage account
+ ///
+ /// Supported keys:
Review Comment:
This is actually one of my main concern. On one hand there simply is quite a
few variants out there people migt be used to, on the other hand, having many
options for the same thing is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
