winding-lines commented on code in PR #3436:
URL: https://github.com/apache/arrow-rs/pull/3436#discussion_r1061075024
##########
object_store/src/aws/mod.rs:
##########
@@ -472,6 +614,49 @@ impl AmazonS3Builder {
self
}
+ /// Set an option on the builder via a key - value pair.
+ pub fn with_option(
+ mut self,
+ key: impl Into<String>,
Review Comment:
@roeap thanks for the super quick turn around time on this one. This is
pretty close to what I am thinking, I would like to suggest one more change?
As an user I would like to have my configuration fully checked by the
compiler. So I would like to either be able to pass in one of the
`AmazonS3ConfigKey`s as the key or have a helper function that returns one of
the string representations. This way in my code I never have to type a string
constant for the key.
Let me know what you think....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
