winding-lines commented on code in PR #3436:
URL: https://github.com/apache/arrow-rs/pull/3436#discussion_r1061122387
##########
object_store/src/aws/mod.rs:
##########
@@ -472,6 +614,49 @@ impl AmazonS3Builder {
self
}
+ /// Set an option on the builder via a key - value pair.
+ pub fn with_option(
+ mut self,
+ key: impl Into<String>,
Review Comment:
I ported my PR to the code so far. I had to toggle back and forth between
the 2 PRs to make sure I get these constants correctly.
https://github.com/pola-rs/polars/pull/5972/files#diff-28ad3830b06d49511094951431beea1edcf6a567f646250482e9f00f769ace27R16
This is error prone specially since you have a type safe Enum sitting right
there...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
