mapleFU commented on code in PR #33703:
URL: https://github.com/apache/arrow/pull/33703#discussion_r1071559580
##########
cpp/src/parquet/encryption/internal_file_decryptor.h:
##########
@@ -76,12 +76,17 @@ class InternalFileDecryptor {
::arrow::MemoryPool* pool() { return pool_; }
+ /// This object must not outlive the InternalFileDecryptor.
std::shared_ptr<Decryptor> GetFooterDecryptor();
+ /// This object must not outlive the InternalFileDecryptor.
std::shared_ptr<Decryptor> GetFooterDecryptorForColumnMeta(const
std::string& aad = "");
+ /// This object must not outlive the InternalFileDecryptor.
std::shared_ptr<Decryptor> GetFooterDecryptorForColumnData(const
std::string& aad = "");
+ /// This object must not outlive the InternalFileDecryptor.
std::shared_ptr<Decryptor> GetColumnMetaDecryptor(
const std::string& column_path, const std::string& column_key_metadata,
const std::string& aad = "");
+ /// This object must not outlive the InternalFileDecryptor.
Review Comment:
fmt?
##########
cpp/src/parquet/column_reader.h:
##########
@@ -151,7 +151,7 @@ class PARQUET_EXPORT PageReader {
}
// @returns: shared_ptr<Page>(nullptr) on EOS, std::shared_ptr<Page>
- // containing new Page otherwise
+ // containing new Page otherwise. This object must not outlive the
PageReader.
Review Comment:
Why, seems that `shared_ptr<Page>` can outlives PageReader, isn't it just a
shared buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
