wgtmac commented on code in PR #33703:
URL: https://github.com/apache/arrow/pull/33703#discussion_r1071668683
##########
cpp/src/parquet/column_reader.h:
##########
@@ -151,7 +151,7 @@ class PARQUET_EXPORT PageReader {
}
// @returns: shared_ptr<Page>(nullptr) on EOS, std::shared_ptr<Page>
- // containing new Page otherwise
+ // containing new Page otherwise. This object must not outlive the
PageReader.
Review Comment:
I would say it is fine if the buffer (as well as the page object) outlives
the PageReader. But its lifecycle is bound to the memory pool which allocates
the buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
