felipecrv commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1090866068
##########
cpp/src/arrow/compare.cc:
##########
@@ -700,6 +734,15 @@ class TypeEqualsVisitor {
return Status::OK();
}
+ Status Visit(const RunEndEncodedType& left) {
+ const auto& right = checked_cast<const RunEndEncodedType&>(right_);
+ // NOTE(felipecrv): the type of the run_ends might differ, but that doesn't
+ // change the logical meaning of the type so only the encoded type is
+ // compared.
Review Comment:
I will make it more strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]