felipecrv commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1091347280
##########
cpp/src/arrow/array/data.cc:
##########
@@ -195,6 +195,7 @@ int GetNumBuffers(const DataType& type) {
case Type::NA:
case Type::STRUCT:
case Type::FIXED_SIZE_LIST:
+ case Type::RUN_END_ENCODED:
return 1;
Review Comment:
From looking at @zeroshade PR, I got reminded that the child `values` array
will have a validity bitmap. That, of course doesn't map to logical validity of
the REE elements, but allows for an `IsValid(i)` at the top-level array that
can be implemented at the cost of binary searching for the physical index of
`i` and checking the validity bitmap of the child `values` array. Maybe that
can make integration easier and allows Acero to improve how it deals with REEs
more incrementally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
