felipecrv commented on code in PR #33641: URL: https://github.com/apache/arrow/pull/33641#discussion_r1092149774
########## cpp/src/arrow/compute/kernel.h: ########## @@ -141,6 +141,14 @@ ARROW_EXPORT std::shared_ptr<TypeMatcher> FixedSizeBinaryLike(); // Type) ARROW_EXPORT std::shared_ptr<TypeMatcher> Primitive(); +/// \brief Match run-end encoded types that encode specific plain data types +/// +/// @param[in] run_ends_type_matcher a matcher that is applied to the run_ends field +/// @param[in] encoded_type_matcher a matcher that is applied to the values field +ARROW_EXPORT std::shared_ptr<TypeMatcher> RunEndEncoded( + std::shared_ptr<TypeMatcher> run_ends_type_matcher, Review Comment: Not really. Instances of this are passing `Primitive()`. I fixed `Matches` to match the integer types more strictly now. And as you said, kernel implementations will template on them on the three possible types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
