felipecrv commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1091314042
##########
cpp/src/arrow/scalar.cc:
##########
@@ -1149,7 +1149,7 @@ Result<std::shared_ptr<Scalar>>
Scalar::CastTo(std::shared_ptr<DataType> to) con
if (is_valid) {
out->is_valid = true;
ToTypeVisitor unpack_to_type{*this, to, out.get()};
- RETURN_NOT_OK(VisitTypeInline(*to, &unpack_to_type));
+ RETURN_NOT_OK(VisitScalarTypeInline(*to, &unpack_to_type));
Review Comment:
And I totally agree. Not having the Scalar is not something we can really
get away with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
