felipecrv commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1092168865
##########
cpp/src/arrow/array/data.cc:
##########
@@ -195,6 +195,7 @@ int GetNumBuffers(const DataType& type) {
case Type::NA:
case Type::STRUCT:
case Type::FIXED_SIZE_LIST:
+ case Type::RUN_END_ENCODED:
return 1;
Review Comment:
> Also you'll notice that IsValid and IsNull are non-virtual methods.
And making them `virtual` would have performance impacts on everything. This
would be a different API just in case kernels need it. More of a `compute`
concern than something to be part of the `ArrayData` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
