mingmwang commented on code in PR #5322:
URL: https://github.com/apache/arrow-datafusion/pull/5322#discussion_r1116448488
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1528,6 +1528,9 @@ impl SessionState {
// repartitioning and local sorting steps to meet distribution and
ordering requirements.
// Therefore, it should run before EnforceDistribution and
EnforceSorting.
Arc::new(JoinSelection::new()),
+ // Enforce sort before PipelineFixer
Review Comment:
I think the comment for `PipelineFixer` need to be adjusted.
```rust
// If the query is processing infinite inputs, the PipelineFixer rule
applies the
// necessary transformations to make the query runnable (if it is not
already runnable).
// If the query can not be made runnable, the rule emits an error with a
diagnostic message.
// Since the transformations it applies may alter output partitioning
properties of operators
// (e.g. by swapping hash join sides), this rule runs before
EnforceDistribution.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
