andygrove commented on a change in pull request #8720:
URL: https://github.com/apache/arrow/pull/8720#discussion_r528225197
##########
File path: rust/datafusion/src/physical_plan/hash_utils.rs
##########
@@ -29,7 +29,7 @@ pub enum JoinType {
}
/// The on clause of the join, as vector of (left, right) columns.
-pub type JoinOn<'a> = [(&'a str, &'a str)];
+pub type JoinOn = [(String, String)];
Review comment:
I ran into ownership issues that I couldn't figure out. I am happy to
change this back if someone can show me how.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
