andygrove commented on a change in pull request #8720:
URL: https://github.com/apache/arrow/pull/8720#discussion_r528231660
##########
File path: rust/datafusion/src/logical_plan/plan.rs
##########
@@ -94,6 +101,21 @@ pub enum LogicalPlan {
/// The incoming logical plan
input: Arc<LogicalPlan>,
},
+ /// Join two logical plans on one or more join columns
+ Join {
+ /// Left input
+ left: Arc<LogicalPlan>,
+ /// Right input
+ right: Arc<LogicalPlan>,
+ /// Columns in left input to use for join keys
+ left_keys: Vec<String>,
+ /// Columns in right input to use for join keys
+ right_keys: Vec<String>,
Review comment:
Thanks. I agree and I have made this change. The user-facing DataFrame
method is now the only plan that accepts the two separate lists of column names
and we verify they are the same length when creating the logical plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
