andygrove commented on a change in pull request #8720:
URL: https://github.com/apache/arrow/pull/8720#discussion_r528226513
##########
File path: rust/datafusion/src/physical_plan/hash_utils.rs
##########
@@ -94,15 +94,19 @@ pub fn build_join_schema(
) -> Schema {
let fields: Vec<Field> = match join_type {
JoinType::Inner => {
- // inner: all fields are there
- let on_right = &on.iter().map(|on|
on.1.to_string()).collect::<HashSet<_>>();
+ // remove right-side join keys if they have the same names as the
left-side
Review comment:
The rustdoc test for `DataFrame.join` was failing until I made this
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
