andygrove commented on a change in pull request #8720:
URL: https://github.com/apache/arrow/pull/8720#discussion_r528228327



##########
File path: rust/datafusion/src/execution/dataframe_impl.rs
##########
@@ -203,6 +224,20 @@ mod tests {
         Ok(())
     }
 
+    #[tokio::test]
+    async fn join() -> Result<()> {
+        let left = test_table()?.select_columns(vec!["c1", "c2"])?;
+        let right = test_table()?.select_columns(vec!["c1", "c3"])?;
+        let left_rows = left.collect().await?;
+        let right_rows = right.collect().await?;
+        let join = left.join(right, JoinType::Inner, &["c1"], &["c1"])?;
+        let join_rows = join.collect().await?;
+        assert_eq!(100, left_rows.len());
+        assert_eq!(100, right_rows.len());
+        assert_eq!(1000, join_rows.len()); //TODO determine expected number 
but should be > 100

Review comment:
       The test currently fails and I need to debug why




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to