tustvold commented on code in PR #3885:
URL: https://github.com/apache/arrow-rs/pull/3885#discussion_r1140533115
##########
arrow-arith/src/arity.rs:
##########
@@ -21,30 +21,25 @@ use arrow_array::builder::BufferBuilder;
use arrow_array::iterator::ArrayIter;
use arrow_array::types::ArrowDictionaryKeyType;
use arrow_array::*;
-use arrow_buffer::buffer::{BooleanBuffer, NullBuffer};
+use arrow_buffer::buffer::NullBuffer;
use arrow_buffer::{Buffer, MutableBuffer};
-use arrow_data::bit_iterator::try_for_each_valid_idx;
-use arrow_data::bit_mask::combine_option_bitmap;
-use arrow_data::ArrayData;
+use arrow_data::{ArrayData, ArrayDataBuilder};
use arrow_schema::ArrowError;
use std::sync::Arc;
#[inline]
unsafe fn build_primitive_array<O: ArrowPrimitiveType>(
len: usize,
buffer: Buffer,
- null_count: usize,
- null_buffer: Option<Buffer>,
+ nulls: Option<NullBuffer>,
Review Comment:
The astute will notice this is precisely the `PrimitiveArray::new_unchecked`
that #3880 proposes to add :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
