tustvold commented on code in PR #3885:
URL: https://github.com/apache/arrow-rs/pull/3885#discussion_r1142751190
##########
arrow-buffer/src/buffer/null.rs:
##########
@@ -50,6 +51,18 @@ impl NullBuffer {
Self { buffer, null_count }
}
+ /// Computes the union of two optional [`NullBuffer`]
+ pub fn union(
Review Comment:
Its union of the nulls, its confusing because a 0 bit is a null... I'll add
further docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
