tustvold commented on code in PR #3885:
URL: https://github.com/apache/arrow-rs/pull/3885#discussion_r1140534089
##########
arrow-string/src/regexp.rs:
##########
@@ -100,15 +99,11 @@ pub fn regexp_is_match_utf8<OffsetSize: OffsetSizeTrait>(
.collect::<Result<Vec<()>, ArrowError>>()?;
let data = unsafe {
- ArrayData::new_unchecked(
- DataType::Boolean,
- array.len(),
- None,
- null_bit_buffer,
- 0,
- vec![result.finish()],
- vec![],
- )
+ ArrayDataBuilder::new(DataType::Boolean)
Review Comment:
A future `BooleanArray::new_unchecked` should clean this up :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
