tustvold commented on code in PR #3885:
URL: https://github.com/apache/arrow-rs/pull/3885#discussion_r1143274050
##########
arrow-arith/src/arity.rs:
##########
@@ -412,14 +388,8 @@ where
Err(err) => return Ok(Err(err)),
};
- let array_builder = builder
- .finish()
- .into_data()
- .into_builder()
- .null_bit_buffer(null_buffer)
- .null_count(null_count);
-
- let array_data = unsafe { array_builder.build_unchecked() };
+ let array_builder = builder.finish().into_data().into_builder();
Review Comment:
PrimitiveBuilder vs ArrayBuilder, this should be greatly simplified with the
ongoing work in #3880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
