icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1142673665
##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -166,6 +171,57 @@ class DefaultExtensionProvider : public
BaseExtensionProvider {
named_tap_rel.name(),
std::move(renamed_schema)));
return RelationInfo{{std::move(decl), std::move(renamed_schema)},
std::nullopt};
}
+
+ Result<RelationInfo> MakeSegmentedAggregateRel(
+ const ConversionOptions& conv_opts, const std::vector<DeclarationInfo>&
inputs,
+ const substrait_ext::SegmentedAggregateRel& seg_agg_rel,
+ const ExtensionSet& ext_set) {
+ if (inputs.size() != 1) {
+ return Status::Invalid(
+ "substrait_ext::SegmentedAggregateRel requires a single input but
got: ",
+ inputs.size());
+ }
+
+ auto input_schema = inputs[0].output_schema;
+
+ ConversionOptions conversion_options;
+
+ // store segment key fields to be used when output schema is created
+ std::vector<int> segment_key_field_ids;
+ std::vector<FieldRef> segment_keys;
+ if (seg_agg_rel.segment_groupings_size() > 0) {
+ ARROW_RETURN_NOT_OK(internal::ParseAggregateGrouping(
+ seg_agg_rel.segment_groupings(0), ext_set, conversion_options,
input_schema,
+ &segment_key_field_ids, &segment_keys));
+ }
+
+ const auto& aggregate = seg_agg_rel.aggregate();
+ ARROW_ASSIGN_OR_RAISE(
+ auto decl_info,
+ internal::ParseAggregateDeclaration(
Review Comment:
I am kind of between here, if we copy the AggregationRel and turn that into
a new SegmentedAggregationRel, then I don't know if there is a reasonable way
to reuse the deser code for AggregationRel (or do we need to copy the code)?
If we use this approach, most of the deser code can be shared but the rel
message looks a bit weird. So I am not sure which way of better.
@westonpace WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
