rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1142728086
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -46,5 +51,39 @@ Result<DeclarationInfo> FromProto(const substrait::Rel&,
const ExtensionSet&,
ARROW_ENGINE_EXPORT Result<std::unique_ptr<substrait::Rel>> ToProto(
const compute::Declaration&, ExtensionSet*, const ConversionOptions&);
+namespace internal {
Review Comment:
Indeed the header file is not public, yet the new functions are not really
meant to be used sparingly, and the `internal` namespace makes this clear at
each call site. I could remove the namespace and add a doc but then the clarity
at the call sites would be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
