rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1142680836
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -58,3 +58,9 @@ message NamedTapRel {
// If empty, field names will be automatically generated.
repeated string columns = 3;
}
+
+message SegmentedAggregateRel {
+ substrait.AggregateRel aggregate = 1;
+
+ repeated substrait.AggregateRel.Grouping segment_groupings = 2;
Review Comment:
This ended up being simpler to implement because it reuses existing parsing
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
