icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1142721042
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -46,5 +51,39 @@ Result<DeclarationInfo> FromProto(const substrait::Rel&,
const ExtensionSet&,
ARROW_ENGINE_EXPORT Result<std::unique_ptr<substrait::Rel>> ToProto(
const compute::Declaration&, ExtensionSet*, const ConversionOptions&);
+namespace internal {
Review Comment:
I don't think this new namespace is really necessary. This header file is
not public anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
