alamb commented on code in PR #5686:
URL: https://github.com/apache/arrow-datafusion/pull/5686#discussion_r1149788705
##########
datafusion/common/src/dfschema.rs:
##########
@@ -630,9 +630,9 @@ impl ExprSchema for DFSchema {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct DFField {
/// Optional qualifier (usually a table or relation name)
- qualifier: Option<OwnedTableReference>,
+ pub qualifier: Option<OwnedTableReference>,
Review Comment:
Can you please explain the rationale for this change?
##########
datafusion/core/tests/sql/mod.rs:
##########
@@ -1161,15 +1161,6 @@ async fn try_execute_to_batches(
/// Execute query and return results as a Vec of RecordBatches
async fn execute_to_batches(ctx: &SessionContext, sql: &str) ->
Vec<RecordBatch> {
let df = ctx.sql(sql).await.unwrap();
-
- // We are not really interested in the direct output of
optimized_logical_plan
Review Comment:
Why was this removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
