rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1151501597
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -46,5 +52,46 @@ Result<DeclarationInfo> FromProto(const substrait::Rel&,
const ExtensionSet&,
ARROW_ENGINE_EXPORT Result<std::unique_ptr<substrait::Rel>> ToProto(
const compute::Declaration&, ExtensionSet*, const ConversionOptions&);
+namespace internal {
+
+/// \brief Parse an aggregate relation's measure
+///
+/// \param[in] agg_measure the measure
+/// \param[in] ext_set an extension mapping to use in parsing
+/// \param[in] conversion_options options to control how the conversion is done
+/// \param[in] input_schema the schema to which field refs apply
+/// \param[in] is_hash whether the measure is a hash one (i.e., aggregation
keys exist)
+/// \param[out] aggregates points to vector to push the parsed measure into
+/// \param[out] agg_src_fieldsets points to vector to push the parsed field
set into
+ARROW_ENGINE_EXPORT Status ParseAggregateMeasure(
Review Comment:
Perhaps something like [the example of
`AsofJoinNode::MakeOutputSchema`](https://github.com/apache/arrow/blob/2c9340dd1795bedcc6a43975e26580b4f27912ad/cpp/src/arrow/compute/exec/asof_join_node.cc#L1318-L1322)
is what you're looking for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
