rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1152464913
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,6 +30,12 @@
#include "substrait/algebra.pb.h" // IWYU pragma: export
namespace arrow {
+namespace compute {
Review Comment:
I understand what you're trying to achieve, however, I think this
refactoring of `options.cc` should be out of scope for this PR and in any case
should probably be into new files rather than into `relation_internal.cc`,
which can't be the right place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
