rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1151919635
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,6 +30,12 @@
#include "substrait/algebra.pb.h" // IWYU pragma: export
namespace arrow {
+namespace compute {
Review Comment:
It is conventional in Arrow to include a type declaration when its
definitions is not needed, e.g., when only a pointer to the type is needed. You
can see examples of this in "*_fwd.h" header files. I believe the basic idea of
this is to minimize dependencies between header files. Having said that, I
recently changed `relation_internal.h` here in a way that requires including
the type definition and so I removed the declaration and included the defining
header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
