rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1151972979
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,6 +30,12 @@
#include "substrait/algebra.pb.h" // IWYU pragma: export
namespace arrow {
+namespace compute {
Review Comment:
I don't see now how we can cleanly avoid exposing the two functions in the
"internal"-namespace without putting the function calling them in an
inappropriate place. If we can do this cleanly, then I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
