icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1151936810
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,6 +30,12 @@
#include "substrait/algebra.pb.h" // IWYU pragma: export
namespace arrow {
+namespace compute {
Review Comment:
I see. I believe if we don't expose these two methods from
relation_internal.h then this we don't need this fwd declaration either. See
https://github.com/apache/arrow/pull/34627#discussion_r1151928873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]