icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1151920290
##########
cpp/src/arrow/engine/substrait/expression_internal.h:
##########
@@ -34,6 +35,15 @@ namespace engine {
class SubstraitCall;
+ARROW_ENGINE_EXPORT
+Result<FieldRef> DirectReferenceFromProto(const
substrait::Expression::ReferenceSegment*,
+ const ExtensionSet&, const
ConversionOptions&);
+
+ARROW_ENGINE_EXPORT
+Result<compute::Expression> FromProto(const
substrait::Expression::ReferenceSegment*,
+ const ExtensionSet&, const
ConversionOptions&,
+ std::optional<compute::Expression>);
Review Comment:
Thanks Weston for the explanation.
+1 on not exposing this in the header file. I think if we move the
MakeSegmentedAggregateRel to expression_internal.cc then we don't need to
expose this via the header file. I have a comment about moving these "make
extension rel" methods out of options.cc anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
