icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1152220398
##########
cpp/src/arrow/engine/substrait/expression_internal.h:
##########
@@ -34,6 +35,15 @@ namespace engine {
class SubstraitCall;
+ARROW_ENGINE_EXPORT
+Result<FieldRef> DirectReferenceFromProto(const
substrait::Expression::ReferenceSegment*,
+ const ExtensionSet&, const
ConversionOptions&);
+
+ARROW_ENGINE_EXPORT
+Result<compute::Expression> FromProto(const
substrait::Expression::ReferenceSegment*,
+ const ExtensionSet&, const
ConversionOptions&,
+ std::optional<compute::Expression>);
Review Comment:
> However, can we remove this prototype from the header file and put it in
an anonymous namespace? I think it should be an internal method and not exposed.
@westonpace Would sth like this look better to you?
https://github.com/apache/arrow/commit/e958b6d6cfd8889fd8e5a616eadfe0023cac3b77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
