icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1152218148
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,6 +30,12 @@
#include "substrait/algebra.pb.h" // IWYU pragma: export
namespace arrow {
+namespace compute {
Review Comment:
Sth like this -
https://github.com/apache/arrow/commit/e958b6d6cfd8889fd8e5a616eadfe0023cac3b77
I moved all things under relation_internal.cc which I think makes the header
file cleaner.
The downside is that the extension logic is now inside relation_internal.cc
which makes that file larger, but I still think this is justifiable because
"aggregate" and "segment aggregate" does share internal logic here. This is
cleaner than exposing the `ParseAggregateMeasure` and
`MakeAggregateDeclaration` in `relation_internal.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
