teo-tsirpanis commented on code in PR #35810:
URL: https://github.com/apache/arrow/pull/35810#discussion_r1210653495
##########
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##########
@@ -184,13 +189,12 @@ private unsafe static void
ConvertRecordBatch(ExportedAllocationOwner sharedOwne
cArray->dictionary = null;
}
+#if NET5_0_OR_GREATER
+ [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvStdcall) })]
Review Comment:
See https://github.com/apache/arrow/pull/34133#discussion_r1122532439.
Ideally we would have used the default calling convention, but that would not
be suppported on anything earlier than .NET 5. And in 64-bit platforms the
calling convention doesn't matter either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
