pitrou commented on code in PR #35810:
URL: https://github.com/apache/arrow/pull/35810#discussion_r1210678633
##########
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##########
@@ -184,13 +189,12 @@ private unsafe static void
ConvertRecordBatch(ExportedAllocationOwner sharedOwne
cArray->dictionary = null;
}
+#if NET5_0_OR_GREATER
+ [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvStdcall) })]
Review Comment:
If you take a look for example at the Arrow C++ implementation, its release
functions are entirely private. For example `ReleaseExportedSchema` below is in
the anonymous namespace, which doesn't expose the function publicly:
https://github.com/apache/arrow/blob/e628ca50078c749ea7a10b53defe12cbec7d581f/cpp/src/arrow/c/bridge.cc#L107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
