pitrou commented on code in PR #35810:
URL: https://github.com/apache/arrow/pull/35810#discussion_r1210675397
##########
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##########
@@ -184,13 +189,12 @@ private unsafe static void
ConvertRecordBatch(ExportedAllocationOwner sharedOwne
cArray->dictionary = null;
}
+#if NET5_0_OR_GREATER
+ [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvStdcall) })]
Review Comment:
Well, why is this `release` member public here? It will be exposed to C Data
Interface consumers as the `release` pointer, but needn't (and probably
shouldn't) be part of the Arrow C# API.
Arrow C# API users should only see the high-level import and export methods
such as `ImportArray` and `ExportArray`.
(an important thing to understand is that the C Data Interface is a _binary_
interface, not an API)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
