pitrou commented on code in PR #35810:
URL: https://github.com/apache/arrow/pull/35810#discussion_r1210657569
##########
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##########
@@ -184,13 +189,12 @@ private unsafe static void
ConvertRecordBatch(ExportedAllocationOwner sharedOwne
cArray->dictionary = null;
}
+#if NET5_0_OR_GREATER
+ [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvStdcall) })]
Review Comment:
Well, the entire point (mostly) of implementing the C Data Interface is to
be compatible with non-.Net producers/consumers. Those are extremely likely to
use the platform default. So we should get it right at least when possible,
i.e. on .Net >= 5.0.
As for
https://stackoverflow.com/questions/34832679/is-the-callingconvention-ignored-in-64-bit-net-applications
, does it apply here? It's talking about `DllImport`, which might be different
from this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
