lidavidm commented on code in PR #799:
URL: https://github.com/apache/arrow-adbc/pull/799#discussion_r1231439862
##########
c/driver/postgresql/connection.cc:
##########
@@ -185,6 +186,10 @@ class PqGetObjectsHelper {
na_error_ = {0};
}
+ static const inline std::unordered_map<std::string, std::string>
PgTableTypes = {
Review Comment:
I think you can just put it outside the class then (shouldn't matter since
this is in a cc file and not a header). Plus we've been trying to avoid C++17
for R's sake (though apparently we don't enforce that!), since some R
distributions still ship with only C++11 support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
