WillAyd commented on code in PR #799:
URL: https://github.com/apache/arrow-adbc/pull/799#discussion_r1231492721
##########
c/validation/adbc_validation.h:
##########
@@ -47,6 +47,13 @@ class DriverQuirks {
return ADBC_STATUS_OK;
}
+ /// \brief Drop the given view. Used by tests to reset state.
+ virtual AdbcStatusCode DropView(struct AdbcConnection* connection,
+ const std::string& name,
+ struct AdbcError* error) const {
+ return ADBC_STATUS_OK;
Review Comment:
Was going to try and make all of the virtual methods here return
NOT_IMPLEMENTED; doing so for the DropTable method yields some sqlite test
errors though. Guessing the quirks checking in that test module is off -
something for later investigation
```sh
/home/willayd/clones/arrow-adbc/c/validation/adbc_validation.cc:1943: Failure
Value of: quirks()->DropTable(&connection, "bulk_ingest", &error)
Expected: is 0 (OK)
Actual: '\x2' (2) (of type unsigned char), 2 (NOT_IMPLEMENTED)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
