lidavidm commented on code in PR #799:
URL: https://github.com/apache/arrow-adbc/pull/799#discussion_r1231443839
##########
c/driver/postgresql/connection.cc:
##########
@@ -185,6 +186,10 @@ class PqGetObjectsHelper {
na_error_ = {0};
}
+ static const inline std::unordered_map<std::string, std::string>
PgTableTypes = {
Review Comment:
Arrow C++ is C++17 indeed; I think what happened here is that I intended for
C++17 (or really, didn't really think about it), but we didn't end up using
anything from C++14 or 17 at all (except in test code), and it turned out to be
more convenient to stick to C++11 in non-test code for now to help R.
@paleolimbot can explain the R part better than I.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
