zeroshade commented on code in PR #37040:
URL: https://github.com/apache/arrow/pull/37040#discussion_r1287407084
##########
cpp/src/arrow/device.h:
##########
@@ -105,6 +107,63 @@ class ARROW_EXPORT Device : public
std::enable_shared_from_this<Device>,
bool is_cpu_;
};
+/// \brief EXPERIMENTAL: An object that provides event/stream sync primitives
+///
+///
+class ARROW_EXPORT DeviceSync {
+ public:
+ explicit DeviceSync(void* sync_event) : sync_event_{sync_event},
owns_event_{false} {}
+ virtual ~DeviceSync() = default;
Review Comment:
The problem with this is that `release_event` is a virtual function which is
a bad idea to call from a destructor, so the current semantics require
explicitly calling `release_event`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
