zeroshade commented on code in PR #37040:
URL: https://github.com/apache/arrow/pull/37040#discussion_r1289215409
##########
cpp/src/arrow/device.h:
##########
@@ -105,6 +107,63 @@ class ARROW_EXPORT Device : public
std::enable_shared_from_this<Device>,
bool is_cpu_;
};
+/// \brief EXPERIMENTAL: An object that provides event/stream sync primitives
+///
+///
+class ARROW_EXPORT DeviceSync {
+ public:
+ explicit DeviceSync(void* sync_event) : sync_event_{sync_event},
owns_event_{false} {}
+ virtual ~DeviceSync() = default;
+
+ /// @brief Block until sync event is completed.
+ ///
+ /// Should be a no-op for CPU devices.
+ virtual Status wait() = 0;
+
+ /// @brief Make the provided stream wait on the sync event.
+ ///
+ /// Tells the provided stream that it should wait until the
+ /// synchronization event is completed without blocking the CPU.
+ /// @param stream Should be appropriate for the underlying device
+ virtual Status stream_wait(void* stream) = 0;
+
+ virtual void set_stream(void* stream) { stream_ = stream; }
+
+ Result<void*> get_event() {
+ if (!sync_event_) {
+ ARROW_ASSIGN_OR_RAISE(sync_event_, create_event());
+ owns_event_ = true;
+ }
+ return sync_event_;
+ }
+
+ void clear_event() {
Review Comment:
Yes, this has to be used instead of just destroying the DeviceSync for the
same reason as above, it's not safe to call a polymorphic virtual function from
a destructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
