zeroshade commented on code in PR #37040:
URL: https://github.com/apache/arrow/pull/37040#discussion_r1289214556
##########
cpp/src/arrow/gpu/cuda_context.cc:
##########
@@ -293,6 +293,12 @@ std::shared_ptr<CudaDevice>
CudaMemoryManager::cuda_device() const {
return checked_pointer_cast<CudaDevice>(device_);
}
+Result<std::shared_ptr<DeviceSync>> CudaMemoryManager::MakeDeviceSync(void*
sync_event) {
+ return nullptr;
+ // auto ev = reinterpret_cast<CUstream*>(sync_event);
+ // return std::make_shared<CudaDeviceSync>(ev);
Review Comment:
Yea, in the next PR I'll implement the Cuda implementations ie: a
`CudaDeviceSync` object etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
