kkraus14 commented on code in PR #37040:
URL: https://github.com/apache/arrow/pull/37040#discussion_r1293627536
##########
cpp/src/arrow/device.h:
##########
@@ -98,6 +100,64 @@ class ARROW_EXPORT Device : public
std::enable_shared_from_this<Device>,
/// \brief Return the DeviceAllocationType of this device
virtual DeviceAllocationType device_type() const = 0;
+ /// \brief EXPERIMENTAL: An object that provides event/stream sync primitives
+ ///
+ ///
+ class ARROW_EXPORT SyncEvent {
+ public:
+ virtual ~SyncEvent() = default;
+
+ /// @brief Block until sync event is completed.
+ ///
+ /// Should be a no-op for CPU devices.
Review Comment:
> But i'm open to removing that statement if you think it would be better to
leave that open for future development to not be restricted with that guarantee.
Yea, I don't see a reason to dictate that it's a no-op for CPU devices. If
it's a no-op that's an implementation detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
