zeroshade commented on code in PR #37040:
URL: https://github.com/apache/arrow/pull/37040#discussion_r1295011055
##########
cpp/src/arrow/device.h:
##########
@@ -98,6 +101,71 @@ class ARROW_EXPORT Device : public
std::enable_shared_from_this<Device>,
/// \brief Return the DeviceAllocationType of this device
virtual DeviceAllocationType device_type() const = 0;
+ /// \brief EXPERIMENTAL: An object that provides event/stream sync primitives
+ class ARROW_EXPORT SyncEvent {
+ public:
+ virtual ~SyncEvent() = default;
+
+ /// @brief Block until sync event is completed.
+ virtual Status wait() = 0;
+
+ /// @brief Make the provided stream wait on the sync event.
+ ///
+ /// Tells the provided stream that it should wait until the
+ /// synchronization event is completed without blocking the CPU.
+ /// @param stream Should be appropriate for the underlying device
+ virtual Status stream_wait(void* stream) = 0;
+
+ void set_stream(void* stream) {
+ stream_ = stream;
+ }
+
+ /// @brief Returns the stored raw event or creates a new one to return.
+ ///
+ /// clear_event should always be called to cleanup afterwards. If this
+ /// creates the event, then clear_event will call release_event
+ /// internally. If this doesn't own the event, then the lifetime should
+ /// be controlled externally to this class.
+ Result<void*> get_event() {
+ if (!sync_event_) {
+ ARROW_ASSIGN_OR_RAISE(sync_event_, create_event());
+ owns_event_ = true;
+ }
Review Comment:
Similar problem as destructors, it's generally not great to call a virtual
method from inside a constructor. I'll see what i can come up with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
