sarutak commented on code in PR #7378:
URL: https://github.com/apache/arrow-datafusion/pull/7378#discussion_r1302178468
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -609,50 +643,100 @@ mod tests {
#[test]
fn in_list_float64() -> Result<()> {
let schema = Schema::new(vec![Field::new("a", DataType::Float64,
true)]);
- let a = Float64Array::from(vec![Some(0.0), Some(0.2), None]);
+ let a = Float64Array::from(vec![
+ Some(0.0),
+ Some(0.2),
+ None,
+ Some(f64::NAN),
+ Some(-f64::NAN),
+ ]);
let col_a = col("a", &schema)?;
let batch = RecordBatch::try_new(Arc::new(schema.clone()),
vec![Arc::new(a)])?;
- // expression: "a in (0.0, 0.2)"
+ // expression: "a in (0.0, 0.1)"
Review Comment:
Some comments are wrong and it's a tiny issue. So I'll fix them within this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
